Comments on Labelled Color Application
Last modified by Djebloun Sidali on 2021/03/17 21:38
Choose the export format from the list below:
Export as Portable Document Format (PDF) using the Web Browser
Export as HyperText Markup Language (HTML)
Hi Sidali,
Interesting concept Some feedback:
- ThemesCode space pages should be hidden, same for pages inside Themes space (the generated pages);
- Themes should have an entry in the Applications panel, read more at http://contrib.xwiki.org/xwiki/bin/view/Main/WebHome#HApplicationDesign
- Your application pages are orphans, run xar:format on pages to check them for such cases
- You have problems with the translations, "xwiki.themes.createTheme" does not find the key (tested for english)
- The picker is not working, tested with IE9, Chrome 31 and Firefox 26
- You could have used the icon from the default Silk icon set
For me is not clear what exactly this application is supposed to do. You mentioned something about a Calendar application, but you don't provide a link to what Calendar application you are referring too. Also maybe this dependency should be marked somewhere.
Thanks
Thanks for your remarks Ecatrina, this is my first contribution, they helped me.
- done for points 1, 3, 4.6
- For point 2: Not necessarily because it is not an application in itself, but must be integrated with another application that it should appear in the panel. Themes in general should be handled in the Admin section
- For point 5: Colorpiker it works very well for me for three browsers mentioned, I tested with two xwiki versions 4.5.2 and 5.2
- For the calendar this is not an app that exists, but just an example of use, I will adapt the description.
But the calendar is under construction, he will come...
Indeed there was a bug for the color picker, I had put the wrong js docs for colorpicker.
it is fixed now.
I'm mentioning the Calendar application, because I've tested with http://extensions.xwiki.org/xwiki/bin/view/Extension/Calendar+Application and is not working.
Is this about XWiki's ColorThemes? I don't fully understand this application's desciption, could you elaborate? Thanks!
Is this about XWiki's ColorThemes?
> No, it's just a new small, simple application that allows you to create objects with two properties 'title' and 'color'.
I don't fully understand this application's desciption, could you elaborate? Thanks!
> ok
How about 'Category Manager' or 'Label Manager' as name for the application?
Ok for Label Manager
Hello Sidali, I looked at the code of the app and I have a few remarks:
I've fixed the download URL property value which was wrongly set to http://extensions.xwiki.org/xwiki/bin/download/Extension/Themes+Application/Themes.xar. It's a very bad practice to use full URLs when referencing pages or attachments in the same wiki since it means if you change the spage, space or name of wiki the link will get broken as it was when I renamed the page...
Also your XAR must have a version, like themes-1.0.xar, especially since you said it's version 1.0. And when you release 1.1 or 2.0 you'll name it themes-1.1.xar or themes-2.0.xar
Also the name could be improved to be in line with the name of this extension which is cqlled Label Manager. I'd use a name like application-label-manager-1.0.xar.
Thanks!
This first contirb allowed me to learn many things that I should not do in the future.. thank for your comments
@Anca :
When user need to create multiple items, by opening multiple borwser tabs, when they click more than one time in the link, they will be redirected to the same doc/form, while he want to have diffrent documents/forms
@ vincent : the xar was renamed